-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-2 revision 1 #250
RFC-2 revision 1 #250
Conversation
Automated Review URLs |
@normanrz : as @will-moore mentioned in ome/ome-ngff-validator#36, would it be possible for us to get temporary but resolvable URLs for this? either 5.0-dev2 or doing everything relatively? |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
@normanrz @joshmoore I remembered that I tried this with the transformations work that also used separate schemas and I had this working by proactively loading the schemas (see https://github.com/ome/ome-ngff-validator/pull/32/files#diff-3274f1a37032fb0ae4e2823def0007c634e869ae0dfc304ff6a12c36513c3a52R172), so I'll give that a try now... EDIT - it worked 👍 |
Co-authored-by: Davis Bennett <[email protected]>
Thanks to everyone for the clarification comments. Merging and sending to reviewers for feedback. As with other PRs, if anyone else would like to submit a more extended review, please send (or open in a PR) a new markdown file following the style of the other files in https://github.com/ome/ngff/tree/main/rfc/2. |
RFC-2 revision 1 SHA: 75b5420 Reason: push, by @joshmoore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
First, I would like to thank the reviewers of RFC-2 for their constructive feedback!
This PR incorporates the feedback from the reviewers in the RFC. The main changes are:
ome
and re-adding aversion
attributeI updated the spec changes in #242.
There is a larger issue about versioning and backwards compatibility that I don't want to solve as part of this RFC. However, I wrote a blog post on image.sc to capture my current thoughts on the topic.