Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up some parts of the label specification #295

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

While I was implementing this over at ome-zarr-models, and it's in my head, I put together a series of clarifications and improvements to the labels part of the specification. I'm opening this now while it's fresh in my head so I don't forget, but this shouldn't be merged into 0.5, and should wait until #276 is resolved.

Changes:

  • Be more clear about what "group" means throughout about by saying "Zarr group" instead of "group"
  • Instead of "MUST be an integer data type", pair "MUST" with the explicit list of data types. This makes it clear that e.g., uint128 is not an acceptable data type, where "MUST be an integer data type" could allow that. (I know that in practice the data types are limited by those in the zarr spec, but better to be expclicit than implicit)
  • Clarify what is meant by "these MUST NOT contain metadata" when it comes to intermediate groups - I interpreted this as the intermediate groups should not contain OME-Zarr metadata, but I'm not 100% sure what the intent was here?

Copy link
Contributor

Automated Review URLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant