Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator info #21

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Creator info #21

merged 3 commits into from
Aug 20, 2024

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Aug 5, 2024

Fixes #16

This adds _creator info e.g.

"_creator": {
        "name": "ome2024-ngff-challenge",
        "version": "0.0.5.post1.dev0+924ff0a"
      },

to image.zarr/zarr.json and to plate.zarr/zarr.json.

NB: if you have installed ome2024-ngff-challenge with pip install -e . then the version given above will return the commit at the install time and it doesn't track subsequent commits/branch that you change to.

@dominikl dominikl self-requested a review August 6, 2024 08:38
@joshmoore
Copy link
Member

At least two other possibilities occur to me:

  • also define this in the RO-Crate
  • only define this in the RO-Crate

cc: @sherwoodf

Getting this in since for human-readability it's definitely better to have it somewhere ASAP. @will-moore, I assume you'll need to add this to your labels PR (#29) as well.

@joshmoore joshmoore merged commit 3407999 into ome:main Aug 20, 2024
5 checks passed
@will-moore will-moore deleted the creator_info branch October 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record the version of the challenge that was used for conversion
2 participants