Some suggestions on the OMERO.movie page #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While "sans" *is* listed on en.wiktionary.org, it seems a bit confusing for users that are neither English native nor French speakers.
Formatting of the script name / reference is actually a matter of
conventions: previous documentation was referring to the script's *file
name* in the first section, whereas the rest of the page is using
something closer to the *client-side representation* ("make movie").
I'd therefore suggest to remove the entire macOS-specific section on how to install mencoder there.
jburel
reviewed
Jun 25, 2024
Co-authored-by: jean-marie burel <[email protected]>
|
Thanks @ehrenfeu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on getting the
Make Moviescript back for our users after upgrading our server (cf. ome/omero-common#45), we did some changes (hopefully improvements) to the corresponding documentation page. Please feel free to merge or cherry-pick them!❤️ Niko