Zoom label #527
Merged
Zoom label #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-moore
reviewed
Nov 9, 2023
| @@ -1299,6 +1299,8 @@ def draw_labels(self, panel, page): | |||
| label_value.append(channel["label"]) | |||
| label_value = " ".join(label_value) | |||
|
|
|||
| elif prop_nf[0] in ["zoom"]: | |||
There was a problem hiding this comment.
The build is failing flake8 checks due to this line
flake8.main.application MainProcess 1787 INFO Found a total of 79 violations and reported 1
./omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py:1302:21: E271 multiple spaces after keyword
There was a problem hiding this comment.
Thanks, I suppressed the extra space, it should be ok now
will-moore
reviewed
Nov 20, 2023
| @@ -605,6 +605,11 @@ <h4>Dynamic properties</h4> | |||
| <td>Dataset ID: [dataset.id]</td> | |||
| <td>Dataset ID: 1654</td> | |||
| </tr> | |||
| <tr> | |||
| <th>Zoom</th> | |||
| <td>[zoom] %</td> | |||
There was a problem hiding this comment.
The % is generated by the [zoom] itself, so you have [zoom] % you actually get [zoom] % %.
So I think you can just remove the % from this line.
There was a problem hiding this comment.
It takes me moment but now I get it. Yes, we can remove the % from the tips.
|
Apart from the minor point above, this is working fine. |
|
Thanks - merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the zoom level in the label list