Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent hang on exit while omero.client keepalive is active #424

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Prevent hang on exit while omero.client keepalive is active #424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5891208
Set daemon status on keepalive thread
DavidStirling Jul 31, 2024
0f8fe1c
logging module has handled this condition for some time
chris-allan Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/omero/util/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,15 +666,9 @@ def run(self):
ctx.stop_event.wait(ctx.sleeptime)
except ValueError:
pass

if isinstance(ctx.stop_event,
omero.util.concurrency.AtExitEvent):
if ctx.stop_event.atexit:
return # Skipping log. See #3260

ctx.logger.info("Halted")

self.thread = Task()
self.thread = Task(daemon=True)
self.thread.ctx = self
self.thread.start()

Expand Down