Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm python, add miniconda to CI #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marimeireles
Copy link

No description provided.

@joshmoore joshmoore closed this Dec 12, 2024
@joshmoore
Copy link
Member

Re-opening to trigger CI since the workflows were disabled after 60 days of inactivity.

@joshmoore joshmoore reopened this Dec 12, 2024
@joshmoore joshmoore closed this Dec 12, 2024
@joshmoore joshmoore reopened this Dec 12, 2024
@joshmoore joshmoore mentioned this pull request Dec 12, 2024
python-version: ${{ matrix.python }}
activate-environment: true
python-version: ${{ matrix.python-version }}
auto-activate-base: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the base environment need to be activated? This is not the recommended practise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion was around not needing the bash -el {0} commands needed e.g. here: https://github.com/ome/conda-bioformats2raw/blob/cb5a3d9a1ce9bfe72a5b5a1067964939236805f0/.github/workflows/condabuild.yml#L20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants