Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify python3 #6363

Merged
merged 4 commits into from
Dec 1, 2023
Merged

specify python3 #6363

merged 4 commits into from
Dec 1, 2023

Conversation

jburel
Copy link
Member

@jburel jburel commented Sep 22, 2023 •
edited
Loading

What this PR does

replace python by python3
this is required when running on rocky9 (new CI)

@jburel jburel requested a review from pwalczysko November 29, 2023 17:03
@pwalczysko
Copy link
Member

Is it worth to fix other occurrences of "python" to "python3" such as

openmicroscopy/components/tools/python.xml

Line 27 in 2db65a9

<exec executable="python" failonerror="@{failonerror}">
as well here ?

pwalczysko
pwalczysko requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #6363 (comment)

@jburel
Copy link
Member Author

jburel commented Nov 29, 2023

Is it worth to fix other occurrences of "python" to "python3" such as

openmicroscopy/components/tools/python.xml

Line 27 in 2db65a9

<exec executable="python" failonerror="@{failonerror}">

as well here ?

This looks like legacy, but it does not hurt to adjust

@jburel
Copy link
Member Author

jburel commented Dec 1, 2023

@pwalczysko adjustment made

pwalczysko
pwalczysko approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jburel jburel merged commit 6a2adc4 into ome:develop Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwalczysko pwalczysko pwalczysko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jburel @pwalczysko