Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README #376

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix README #376

merged 1 commit into from
Aug 26, 2024

Conversation

pwalczysko
Copy link
Member

Fixes #375 - the README is outdated in 2 points:

  1. It does not specify that the playbooks are working with CentOS 7 OS.
  2. It points to ome-ansible-molecule which is not used anymore

@MartinDerHettich

@pwalczysko pwalczysko requested a review from sbesson August 23, 2024 14:58
@pwalczysko
Copy link
Member Author

@sbesson imho, although the tests are failing (I believe because the CentOS 7 mirror cannot be found as CentOS is EOF), this PR should prevent needless install attempts such as #375

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no longer involved in these playbooks so you might want a review from an active maintainer.

If the goal is to eventually update this repository with new RHEL9 playbooks, the warning makes sense to me. If the playbooks are not expected to be updated, it might make sense to go one step further and mark this repository as read-only.

@pwalczysko pwalczysko requested a review from jburel August 25, 2024 14:40
@joshmoore
Copy link
Member

I'm going to merge as an immediate improvement on the former situation. There are definitely a number of additional options we can then consider:

  • update the playbooks with the in-progress RHEL9 versions
  • separate the playbooks into separate versioned directories
  • archive the repo with a note pointing to the new starting point (perhaps just the roles themselves)

@joshmoore joshmoore merged commit adc782f into ome:master Aug 26, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ome-ansible-molecule fails to build, PyYAML subprocess-exited-with-error in cython_sources
3 participants