Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue about socke_id #57

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Address issue about socke_id #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions core/drivers/pmd.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,11 @@ static CommandResponse find_dpdk_port_by_id(dpdk_port_t port_id,
if (!rte_eth_dev_is_valid_port(port_id)) {
return CommandFailure(ENODEV, "Port id %d is not available", port_id);
}
if (rte_eth_dev_socket_id(port_id) < 0) {
return CommandFailure(ENODEV, "Port id %d is not attached", port_id);
}
if (rte_eth_dev_socket_id(port_id) >= 0 &&
thakurajayL marked this conversation as resolved.
Show resolved Hide resolved
rte_eth_dev_socket_id(port_id) != (int)rte_socket_id())
LOG(WARNING) << "DPDK port_id " << port_id
<< " is on remote NUMA node to polling thread.\n\t"
"Performance will not be optimal.";

*ret_port_id = port_id;
return CommandSuccess();
Expand Down