graph: backend: dnnl: fix the null pointer issue and remove unused code #2504
+3
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make test |
rongzha1
reviewed
Jan 24, 2025
| @@ -142,13 +142,6 @@ void sdp_primitive_kernel_t<quantized>::prepare_args_set( | |||
| mem_idx.first.set_data_handle( | |||
| outputs[mem_idx.second].get_data_handle()); | |||
| } | |||
|
|
|||
| grantor_t var_grantor = memory_planner_.internal_temporary_grantor( | |||
There was a problem hiding this comment.
could you explain why remove these code?
Do we need to check if scratchpad is needed ?
There was a problem hiding this comment.
Sdp_primitive doesn't need scratchpad memory, so we set the scratchpad memory size is 0 in L227. So we don't need to set the data handle for the internal memory.
gyhintel
force-pushed
the
gyh/main/fix-nullptr
branch
from
31f1e16 to
fbd6bc0
Compare
|
make test |
TaoLv
reviewed
Jan 24, 2025
| @@ -215,6 +215,7 @@ class grantor_t { | |||
| } | |||
|
|
|||
| char *get(const registry_t::key_t &key) const { | |||
| if (aligned_base_ptr_ == nullptr) return nullptr; | |||
| return aligned_base_ptr_ + registry_.get(key); | |||
There was a problem hiding this comment.
nit:
Suggested change
| return aligned_base_ptr_ + registry_.get(key); | |
| return aligned_base_ptr_ ? (aligned_base_ptr_ + registry_.get(key)) : nullptr; |
xiang1guo
approved these changes
Jan 24, 2025
rongzha1
approved these changes
Jan 25, 2025
gyhintel
force-pushed
the
gyh/main/fix-nullptr
branch
from
fbd6bc0 to
dc994c8
Compare
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
applying non-zero offset 150994944 to null pointer