Refactor command update API to take a list of configurations #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
EwanC
force-pushed
the
ewan/update_list
branch
6 times, most recently
from
de05080 to
c14f5ef
Compare
EwanC
changed the title
EwanC
force-pushed
the
ewan/update_list
branch
4 times, most recently
from
4993b39 to
7c4a9af
Compare
EwanC
commented
Feb 6, 2025
Comment on lines
+8408
to
+8410
| pUpdateKernelLaunchLocal.hCommand = | ||
| reinterpret_cast<ur_exp_command_buffer_command_object_t *>( | ||
| pUpdateKernelLaunchLocal.hCommand) | ||
| ->handle; |
There was a problem hiding this comment.
This needs to loop over every pUpdateKernelLaunchLocal element in the list and do this translation but can't because of https://oneapi-src.github.io/unified-runtime/core/CONTRIB.html#limitations
There was a problem hiding this comment.
Created #2671 to track this
EwanC
force-pushed
the
ewan/update_list
branch
3 times, most recently
from
75f908b to
e9c7851
Compare
EwanC
changed the title
Update the `urCommandBufferUpdateKernelLaunchExp` API for updating commands in a command-buffer to take a list of commands. The current API operates on a single command, this means that the SYCL-Graph `update(std::vector<nodes>)` API needs to serialize the list into N calls to the UR API. Given that both OpenCL `clUpdateMutableCommandsKHR` and Level-Zero `zeCommandListUpdateMutableCommandsExp` can operate on a list of commands, this serialization at the UR layer of the stack introduces extra host API calls. This PR improves the `urCommandBufferUpdateKernelLaunchExp` API so that a list of commands is passed all the way from SYCL to the native backend API.
EwanC
force-pushed
the
ewan/update_list
branch
from
e9c7851 to
7d3e81f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
urCommandBufferUpdateKernelLaunchExpAPI for updating commands in a command-buffer to take a list of commands.The current API operates on a single command, this means that the SYCL-Graph
update(std::vector<nodes>)API needs to serialize the list into N calls to the UR API. Given that both OpenCLclUpdateMutableCommandsKHRand Level-ZerozeCommandListUpdateMutableCommandsExpcan operate on a list of commands, this serialization at the UR layer of the stack introduces extra host API calls.This PR improves the
urCommandBufferUpdateKernelLaunchExpAPI so that a list of commands is passed all the way from SYCL to the native backend API.Blocked by issue #2671