[DeviceASAN][bugfix] Not allow concurrent kernel launches across different queue #2679
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingcong-wu
changed the title
AllanZyne
approved these changes
Feb 8, 2025
yingcong-wu
force-pushed
the
yc/0208-ur-dasan-bugfix-main
branch
from
efe628f to
029ef10
Compare
yingcong-wu
force-pushed
the
yc/0208-ur-dasan-bugfix-main
branch
from
029ef10 to
fd60baf
Compare
|
Current UR head will have CI failures because #2606 is merged but its intel/llvm part intel/llvm#16747 is not merged. |
|
From the CI steps, it seems my PR will be merged to latest UR head before building (instead of directly using my branch). Therefore there is nothing I can do here. |
pbalcer
reviewed
Feb 10, 2025
|
I removed all other required reviewers since this only touches the sanitizer layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not allow concurrent kernel launches across different queues as the local/private shadow memory implementation does not support it.
intel/llvm PR: intel/llvm#16935