Recognize all file big chunks #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlaci
requested changes
Nov 26, 2021
kissgyorgy
requested changes
Nov 26, 2021
From manual testing it looks like this is the default, but there is no mention about this in the yara-python documentation
This function is very complex and its core to have high cyclomatic complexity. We could move some things around but at this point its easier to see the core logic in one place.
kukovecz
force-pushed
the
23-recognize-all-file-big-chunks
branch
from
42d05e8 to
b828094
Compare
kissgyorgy
approved these changes
Nov 26, 2021
kukovecz
requested review from
vlaci and
kissgyorgy
and removed request for
vlaci
kissgyorgy
requested review from
vlaci
and removed request for
kissgyorgy and
vlaci
vlaci
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple small corrections here, check commit-by-commit
Fixes #23