Skip to content

Commit

Permalink
Manually update CHANGELOG (and remove step doing that from CI for now)
Browse files Browse the repository at this point in the history
  • Loading branch information
dvacca-onfido committed Jun 24, 2024
1 parent d0851a2 commit 75cdbe7
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 28 deletions.
28 changes: 0 additions & 28 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,31 +83,3 @@ jobs:
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
- name: Update CHANGELOG.md
run: |
TMP_FILE=$(mktemp)
RELEASE_VERSION=$(jq -r '.release' .release.json)
RELEASE_DATE=`date +'%dth %B %Y' | sed -E 's/^0//;s/^([2,3]?)1th/\11st/;s/^([2]?)2th/\12nd/;s/^([2]?)3th/\13rd/'`
SPEC_COMMIT_SHA=$(jq -r '.source.short_sha' .release.json)
SPEC_COMMIT_URL=$(jq -r '.source.repo_url + "/commit/" + .source.long_sha' .release.json)
SPEC_RELEASE_VERSION=$(jq -r '.source.version' .release.json)
SPEC_RELEASE_URL=$(jq -r '.source.repo_url + "/releases/tag/" + .source.version' .release.json)
echo -e "# Changelog\n\n## $RELEASE_VERSION $RELEASE_DATE\n\n" >| $TMP_FILE
echo -en "${{ github.event.release.body }}\nBased on Onfido OpenAPI spec " >> $TMP_FILE
if [ -z $SPEC_RELEASE_VERSION ]; then
echo "up to commit [$SPEC_COMMIT_SHA](${SPEC_COMMIT_URL})." >> $TMP_FILE
else
echo "version [$SPEC_RELEASE_VERSION](${SPEC_RELEASE_URL})." >> $TMP_FILE
fi
grep -v "^# Changelog" CHANGELOG.md >> $TMP_FILE
mv $TMP_FILE CHANGELOG.md
git config user.name "GitHub Actions Bot"
git config user.email "<>"
git commit -m "Update CHANGELOG.md after library release" CHANGELOG.md
git push
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## v3.2.0 24th June 2024

- Library has been rebuilt from scratch and automatically generated on [Onfido OpenAPI Spec](https://github.com/onfido/onfido-openapi-spec) (release [v3.0.0](https://github.com/onfido/onfido-openapi-spec/releases/tag/v3.0.0))
- Integration tests have been refreshed and API coverage increased

## v3.1.0 13th May 2024 (pre-release)

- Include `nexus-staging-maven-plugin` only when necessary
Expand Down
8 changes: 8 additions & 0 deletions src/test/java/com/onfido/integration/ReportSchemasTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public void schemaOfFacialSimilarityPhotoReportIsValid() throws Exception {
Assertions.assertEquals(
ReportName.FACIAL_SIMILARITY_PHOTO_FULLY_AUTO,
facialSimilarityPhotoFullyAutoReport.getName());
<<<<<<< HEAD
Assertions.assertEquals(
check.getId(), facialSimilarityPhotoFullyAutoReport.getReportShared().getCheckId());
Assertions.assertNotNull(
Expand All @@ -88,5 +89,12 @@ public void schemaOfFacialSimilarityPhotoReportIsValid() throws Exception {
facialSimilarityPhotoFullyAutoReport
.getFacialSimilarityPhotoFullyAutoReport()
.getProperties());
=======
Assertions.assertEquals(check.getId(), facialSimilarityPhotoFullyAutoReport.getCheckId());
Assertions.assertNotNull(facialSimilarityPhotoFullyAutoReport.getBreakdown());
Assertions.assertNotNull(facialSimilarityPhotoFullyAutoReport.getResult());
Assertions.assertNotNull(
facialSimilarityPhotoFullyAutoReport.getAdditionalProperties().get("properties"));
>>>>>>> parent of cbfbd93 (Fix CHANGELOG and improve CI and tests)
}
}

0 comments on commit 75cdbe7

Please sign in to comment.