Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Add GetTests function #253

Merged
merged 5 commits into from
Nov 30, 2023
Merged

[Test] Add GetTests function #253

merged 5 commits into from
Nov 30, 2023

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Nov 30, 2023 •
edited
Loading

Closes #252

Description

Adds runner.GetTests to get all the available tests in a file

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink changed the title [Test] Add runner.GetTests function [Test] Add GetTests function Nov 30, 2023
SupunS
SupunS approved these changes Nov 30, 2023
View reviewed changes
test/test_framework_test.go Outdated Show resolved Hide resolved
test/test_framework_test.go Outdated Show resolved Hide resolved
test/test_framework_test.go Outdated Show resolved Hide resolved
bjartek
bjartek approved these changes Nov 30, 2023
View reviewed changes
Copy link

@bjartek bjartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jribbink jribbink merged commit 4348860 into master Nov 30, 2023
6 checks passed
@jribbink jribbink deleted the jribbink/get-tests branch December 1, 2023 18:34
jribbink added a commit that referenced this pull request Jan 2, 2024
@jribbink
[Test] Add GetTests function (#253)
9c7f5a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjartek bjartek bjartek approved these changes

@dsainati1 dsainati1 dsainati1 approved these changes

@SupunS SupunS SupunS approved these changes

@turbolent turbolent Awaiting requested review from turbolent turbolent is a code owner

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Test] Add functionality to get available tests in file
4 participants
@jribbink @bjartek @dsainati1 @SupunS