Allow declaration of events in interfaces #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit c9938e6 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## feature/stable-cadence #2662 +/- ##
==========================================================
+ Coverage 78.90% 79.41% +0.50%
==========================================================
Files 342 336 -6
Lines 81650 80178 -1472
==========================================================
- Hits 64430 63675 -755
+ Misses 14871 14207 -664
+ Partials 2349 2296 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…to sainati/interface-events
…to sainati/interface-events
|
@dsainati1 Is this PR marked as a draft because the FLIP isn't approved yet, or is there still something missing code-wise? |
Yes, if the design is approved as-is, this implementation is complete, so it's ready to be reviewed. |
turbolent
approved these changes
Aug 3, 2023
SupunS
reviewed
Aug 11, 2023
No. There's a test for that in the PR already I think as well. |
SupunS
approved these changes
Aug 15, 2023
…to sainati/interface-events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2602
Allows contract interfaces to declare events as their own types, rather than implicitly using such declarations to create type requirements. Currently, these declarations are only in scope within the body of the interface, and thus can only be emitted in default implementations or in pre/post conditions in these interfaces, but subject to the discussion in onflow/flips#118 this may change.
masterbranchFiles changedin the Github PR explorer