Implement modulo argument of revertibleRandom
#2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
added
the
Language Breaking Change
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 9c630d3 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
==========================================
+ Coverage 80.21% 80.29% +0.08%
==========================================
Files 359 359
Lines 84285 84484 +199
==========================================
+ Hits 67607 67837 +230
+ Misses 14247 14223 -24
+ Partials 2431 2424 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tarakby
changed the title
revertibleRandom with modulo argument
tarakby
changed the title
revertibleRandom with modulo argumentrevertibleRandom with a modulo argument
tarakby
commented
Dec 22, 2023
tarakby
requested review from
turbolent,
SupunS and
dsainati1
as code owners
turbolent
changed the title
revertibleRandom with a modulo argumentrevertibleRandom
|
@AlexHentschel Could you please review the implementation? |
|
I improved the tests in 0f775bc: Each test case (which potentially might run in concurrently) should use its own |
turbolent
approved these changes
Jan 9, 2024
|
@dsainati1 @SupunS Could you also please have a look? |
|
@thanks @turbolent for the comments and commits. |
added 2 commits
January 9, 2024 19:27
…w/cadence into tarak/2712-revertibleRandom-modulo
dsainati1
approved these changes
Jan 9, 2024
|
@tarakby can you please have a look at the new commits?
|
|
Nice, thanks @turbolent 👌🏼 I added a minor improvement in 41117f8. The PR is ready for merging. |
|
@tarakby Sounds good! 41117f8 looks good 👌 Agreed, the PR should be ready for review now. @dsainati1 @SupunS could you please have a final look? |
dsainati1
approved these changes
Jan 10, 2024
SupunS
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2712
Description
Specifically the item:
Docs is updated in a separate PR against the doc repo: onflow/cadence-lang.org#37
masterbranchFiles changedin the Github PR explorer