Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port security fixes #3654

Merged
merged 19 commits into from
Oct 30, 2024
Merged

Port security fixes #3654

merged 19 commits into from
Oct 30, 2024

Conversation

turbolent
Copy link
Member

Description

Merge v1.0 branch, which includes #3653, into master

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

SupunS and others added 18 commits October 8, 2024 20:22
@SupunS
v1.0.1
fc7df6c
@turbolent
Merge pull request #3605 from onflow/release/v1.0.1
ea09836
@turbolent
prevent predeclared members to get confused using user-defined types
487e31a
@turbolent
forbid attachment conformances
5f28dda
@turbolent
forbid change of attachment base type
3f384d5
@turbolent
put attachment base type change validation behind a feature flag
1e6ee46
@turbolent
put attachment conformances behind feature flag
7849504
@turbolent
put sibling type check for members behind a feature flag
605fc95
@turbolent
invert feature flag
74b0135
@turbolent
enable v1.0.1 features based on current version
03826a5
@turbolent
rename new version function
8ae61ac
@turbolent
update to latest version of golang.org/x/crypto
88dbd9d
@turbolent
remove feature flags
02cd846
@turbolent
add error return value to MinimumRequiredVersion interface function
e996077
@turbolent
make EmptyRuntimeInterface.MinimumRequiredVersion a no-op
ee97355
@turbolent
return a valid semver
bc01ae1
@turbolent
Merge pull request #3653 from onflow/bastian/port-security-fixes
c9db8c7
@turbolent
Merge branch 'v1.0' into bastian/port-security-fixes-2
98b9dc3
@turbolent turbolent requested a review from jsproz October 30, 2024 14:59
@turbolent turbolent self-assigned this Oct 30, 2024
@turbolent turbolent requested a review from SupunS as a code owner October 30, 2024 14:59
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 1399a6d
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit efe9b38 into master Oct 30, 2024
10 of 12 checks passed
@turbolent turbolent deleted the bastian/port-security-fixes-2 branch October 30, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@turbolent turbolent

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS