Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port internal fixes #3740

Merged
merged 83 commits into from
Jan 29, 2025
Merged

Port internal fixes #3740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
292081d
v1.0.3
turbolent Nov 21, 2024
68cba90
Merge pull request #3685 from onflow/release/v1.0.3
turbolent Nov 21, 2024
1d021b1
Implement atree.WrapperValue and atree.WrapperStorable
fxamacker Dec 24, 2024
9d82cd4
Update CI
Kay-Zee Dec 27, 2024
590c66e
Fix the lint job as well
Kay-Zee Dec 27, 2024
edca885
Lint
fxamacker Dec 27, 2024
179083c
Add integration test using a hardcoded seed
fxamacker Jan 2, 2025
c3f567d
Implement updated atree.WrapperStorable interface
fxamacker Jan 3, 2025
f4c9f5b
Update TestInterpretInvalidNilCoalescingResourceDuplication test to m…
SupunS Jan 6, 2025
350a160
Update comments
fxamacker Jan 6, 2025
8d9cf5b
Fix memory metering tests
SupunS Jan 6, 2025
65e6c53
Update comment
fxamacker Jan 6, 2025
e4950e0
Refactor tests
fxamacker Jan 6, 2025
48adefa
Update atree version
fxamacker Jan 6, 2025
74ddc8e
port Supun's reproducers from flow-go/FVM
turbolent Jan 7, 2025
6120350
try to add reproducer tests for some value issues
turbolent Jan 7, 2025
684ca4d
update values again, improve test names, add test for arrays
turbolent Jan 7, 2025
13f79cd
add missing commits
turbolent Jan 7, 2025
5e0df33
refactor tests, add variants with doubly-nested optionals
turbolent Jan 8, 2025
e44871d
limit memory allocations during bit shift operations for Int128, UInt…
Jan 8, 2025
0bd0f43
add tests that nest optional containers on multiple levels
turbolent Jan 8, 2025
507fa6b
Update atree version to latest
fxamacker Jan 9, 2025
8603464
fix constructors for unsigned integer values
turbolent Jan 10, 2025
c7ce25e
remove unnecessary allocations
Jan 13, 2025
9dd001f
Updated version.
Jan 13, 2025
0f9df09
refactor value smoke tests to generate cadence.Values and commit betw…
turbolent Jan 14, 2025
e8d5a3a
check values before reset of storage
turbolent Jan 14, 2025
10909c3
revert defaults for flags, remove dead code
turbolent Jan 14, 2025
fa33dab
only check storage health if atree validation is enabled
turbolent Jan 14, 2025
07c12fb
fix index generation
turbolent Jan 14, 2025
9da9027
add tests for composite values, set field names of generated composit…
turbolent Jan 14, 2025
6e84f1e
make limits of random value generator configurable
turbolent Jan 14, 2025
00032e3
Bump atree version
fxamacker Jan 15, 2025
9db2d99
Lint
fxamacker Jan 15, 2025
eaa609b
remove extra comparisons and use bits.UintSize
Jan 15, 2025
ca25a8f
add tests for truncate function
Jan 15, 2025
1154cc5
clean up
turbolent Jan 15, 2025
3adbcab
pass subtest's testing.T, improve random value generation
turbolent Jan 15, 2025
6dfc2e9
refactor dictionary tests
turbolent Jan 15, 2025
2a09f8f
refactor composite tests
turbolent Jan 16, 2025
bf7f7e6
refactor array tests
turbolent Jan 16, 2025
00c2d44
add tests for signed cases
tarakby Jan 16, 2025
b025344
adjust left shift implementation for signed integers
tarakby Jan 16, 2025
dad02f7
remove unnecessary manual slab removal
turbolent Jan 16, 2025
c72a22d
add more health checks
turbolent Jan 16, 2025
5194f52
make generated values deeper and less wide
turbolent Jan 16, 2025
1ae4799
Update runtime/tests/interpreter/values_test.go
turbolent Jan 16, 2025
3ddb0bc
remove unnecessary duplicate resets and checks
turbolent Jan 16, 2025
bd43050
add value smoke tests that mutate nested containers
turbolent Jan 17, 2025
4dde5d0
simplify
turbolent Jan 17, 2025
c6c8dc3
fix lint
turbolent Jan 17, 2025
e7f9109
refactor removal from storage map into function
turbolent Jan 17, 2025
9991364
check iteration after performing operation
turbolent Jan 17, 2025
0bd5785
implement nested value finding for interpreter.Value
turbolent Jan 17, 2025
43b54ff
Do not always cache SomeStorable in SomeValue
fxamacker Jan 17, 2025
615dcf7
Bump atree version
fxamacker Jan 17, 2025
e237598
refactor nested container tests
turbolent Jan 18, 2025
b35fa77
test read-only loaded iteration when child is some non-inlined value
turbolent Jan 18, 2025
cf1cd1d
Update runtime/tests/interpreter/values_test.go
turbolent Jan 21, 2025
991a03c
test inlining and uninlining of dictionary nested in some value
turbolent Jan 21, 2025
aaf07b4
use existing Inlined method
turbolent Jan 21, 2025
a53476d
test inlining and uninlining of array nested in some value
turbolent Jan 21, 2025
3ce173b
test starting with unlined state
turbolent Jan 21, 2025
6f8d222
use NegativeShiftError consistently
Jan 21, 2025
ff17065
test composite values
turbolent Jan 21, 2025
a1a3d27
move negative shift tests into their own test function
Jan 21, 2025
6509dd6
pass correct testing.T of subtest
turbolent Jan 21, 2025
308c682
end tests with health checks and validation after storage reset and r…
turbolent Jan 21, 2025
659ebc2
remove unused functions
turbolent Jan 21, 2025
4f4a02d
improve naming
turbolent Jan 22, 2025
1ea3986
pass subtest testing.T
turbolent Jan 22, 2025
6d2df92
improve naming of tests
turbolent Jan 22, 2025
6e54fc9
update to atree v0.9.0
turbolent Jan 27, 2025
1c03fb7
Revert "Update CI"
turbolent Jan 27, 2025
ce6f542
Revert "Fix the lint job as well"
turbolent Jan 27, 2025
8d4b817
Merge pull request #3737 from onflow/bastian/port-fixes
turbolent Jan 27, 2025
f919fee
update dependencies
turbolent Jan 27, 2025
4bc7151
fix version
turbolent Jan 27, 2025
8670104
Merge branch 'v1.0' into bastian/port-fixes-master
turbolent Jan 28, 2025
7a4cfae
bring back missing interface
turbolent Jan 28, 2025
7a6db92
add missing imports, adjust tests to new APIs
turbolent Jan 28, 2025
9fb44fd
disable storage validation while writing value to storage map
turbolent Jan 28, 2025
c103432
go mod tidy
turbolent Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ require (
github.com/kr/pretty v0.3.1
github.com/leanovate/gopter v0.2.9
github.com/logrusorgru/aurora/v4 v4.0.0
github.com/onflow/atree v0.8.1
github.com/onflow/atree v0.9.0
github.com/rivo/uniseg v0.4.4
github.com/schollz/progressbar/v3 v3.13.1
github.com/stretchr/testify v1.10.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db h1:62I3jR2Em
github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db/go.mod h1:l0dey0ia/Uv7NcFFVbCLtqEBQbrT4OCwCSKTEv6enCw=
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWbfPhv4DMiApHyliiK5xCTNVSPiaAs=
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno=
github.com/onflow/atree v0.8.1 h1:DAnPnL9/Ks3LaAnkQVokokTBG/znTW0DJfovDtJDhLI=
github.com/onflow/atree v0.8.1/go.mod h1:FT6udJF9Q7VQTu3wknDhFX+VV4D44ZGdqtTAE5iztck=
github.com/onflow/atree v0.9.0 h1:M+Z/UPwzv0/Yy7ChI5T1ZIHD3YN1cs/hxGEs/HWhzaY=
github.com/onflow/atree v0.9.0/go.mod h1:FT6udJF9Q7VQTu3wknDhFX+VV4D44ZGdqtTAE5iztck=
github.com/onflow/crypto v0.25.0 h1:BeWbLsh3ZD13Ej+Uky6kg1PL1ZIVBDVX+2MVBNwqddg=
github.com/onflow/crypto v0.25.0/go.mod h1:C8FbaX0x8y+FxWjbkHy0Q4EASCDR9bSPWZqlpCLYyVI=
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
Expand Down
Loading
Loading