Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Compile dictionary expressions, implement NewDictionary instruction #3747

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jan 30, 2025

Work towards #3742

Description

  • Compile dictionary expression
  • Add NewDictionary instruction in spec and implement it in the VM
  • Add some tests for the compilation of arrays and dictionary expressions
  • Fix bug in DictionaryValue.Transfer

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 113c09f
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@turbolent turbolent merged commit 03ea43b into feature/compiler Jan 30, 2025
9 checks passed
@turbolent turbolent deleted the bastian/compile-dictionary branch January 30, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants