Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Document stack effects of instructions in their description #3759

Merged

Conversation

turbolent
Copy link
Member

Work towards #3742

Description

Improve the description of the instructions by describing the stack effects (pops and pushes)


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Documentation Improvements or additions to documentation label Feb 5, 2025
@turbolent turbolent self-assigned this Feb 5, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 5, 2025 20:01
Copy link

github-actions bot commented Feb 5, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 4f9641f
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent requested a review from jsproz February 5, 2025 20:55
@turbolent turbolent merged commit 6443aa9 into feature/compiler Feb 5, 2025
9 checks passed
@turbolent turbolent deleted the bastian/document-stack-effects-in-comments branch February 5, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants