Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FCL Ethereum Provider chainChanged Event #2096

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Implement FCL Ethereum Provider chainChanged Event #2096

merged 3 commits into from
Feb 3, 2025

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jan 30, 2025 •
edited
Loading

Closes #2068

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 785d53d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink changed the base branch from master to feature/cross-vm January 30, 2025 05:32
@jribbink jribbink changed the base branch from feature/cross-vm to jribbink/observables January 31, 2025 19:47
@jribbink jribbink marked this pull request as ready for review January 31, 2025 20:22
@jribbink jribbink requested a review from a team as a code owner January 31, 2025 20:22
@jribbink jribbink marked this pull request as draft January 31, 2025 20:28
Base automatically changed from jribbink/observables to feature/cross-vm January 31, 2025 23:42
@jribbink jribbink force-pushed the jribbink/chain-changed branch from d0e593f to e0b2df0 Compare February 1, 2025 00:14
@jribbink jribbink marked this pull request as ready for review February 2, 2025 00:00
@jribbink jribbink requested a review from chasefleming February 2, 2025 00:43
This was referenced Feb 2, 2025
Merged
Closed
chasefleming
chasefleming reviewed Feb 3, 2025
View reviewed changes
packages/fcl-ethereum-provider/src/network/network-manager.ts
const $config = new BehaviorSubject<Record<string, unknown> | null>(null)
config.subscribe((cfg, err) => {
if (err) {
$config.error(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you supposed to throw errors in observables vs do something like $config.next({ error: err })? Do you want it to terminate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case errors are fatal, so we should propogate this through the observable chain

@jribbink jribbink requested a review from chasefleming February 3, 2025 20:28
@jribbink jribbink merged commit b2f9026 into feature/cross-vm Feb 3, 2025
1 check passed
@jribbink jribbink deleted the jribbink/chain-changed branch February 3, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jribbink @chasefleming