Use channel of pointers to objects for consistency #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-malachyn
requested review from
janezpodhostnik,
chasefleming,
nvdtf and
jribbink
as code owners
illia-malachyn
commented
Nov 5, 2024
|
cc @peterargue |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 56.59% 57.47% +0.88%
==========================================
Files 35 35
Lines 7305 7454 +149
==========================================
+ Hits 4134 4284 +150
+ Misses 2670 2660 -10
- Partials 501 510 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
Jan 2, 2025
illia-malachyn
commented
Jan 15, 2025
illia-malachyn
commented
Jan 15, 2025
peterargue
approved these changes
Jan 28, 2025
| if m == nil { | ||
| return flow.BlockHeader{}, ErrEmptyMessage | ||
| return &flow.BlockHeader{}, ErrEmptyMessage |
There was a problem hiding this comment.
I think this can also be nil
Suggested change
| return &flow.BlockHeader{}, ErrEmptyMessage | |
| return nil, ErrEmptyMessage |
| @@ -346,10 +346,10 @@ func MessageToBlockHeader(m *entities.BlockHeader) (flow.BlockHeader, error) { | |||
|
|
|||
| timeoutCertificate, err := MessageToTimeoutCertificate(m.GetLastViewTc()) | |||
| if err != nil { | |||
| return flow.BlockHeader{}, fmt.Errorf("error converting timeout certificate: %w", err) | |||
| return &flow.BlockHeader{}, fmt.Errorf("error converting timeout certificate: %w", err) | |||
| if m == nil { | ||
| return flow.BlockDigest{}, ErrEmptyMessage | ||
| return &flow.BlockDigest{}, ErrEmptyMessage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the access interface of some endpoints. I'm not sure if I should've done this