Outside imports #24
Outside imports #24
Conversation
|
@psiemens :) This will be a small step for Jan's comment from before! If we do this, we can potentially have more complicated account setup steps in the emulator (after deploying the contract!) |
| } | ||
|
|
||
| // ReadWithAddresses loads a .cdc file with its addresses | ||
| func ReadWithAddresses(filename string, addressMap map[string]string) []byte { |
There was a problem hiding this comment.
| func ReadWithAddresses(filename string, addressMap map[string]string) []byte { | |
| func readWithAddresses(filename string, addressMap map[string]string) []byte { |
I don't think this function needs to be exported
| SetupAccountTransaction = "transactions/setup_account.cdc" | ||
| SellItemTransaction = "transactions/sell_item.cdc" | ||
| BuyItemTransaction = "transactions/buy_item.cdc" | ||
| RemoveItemTransaction = "transactions/remove_item.cdc" | ||
| CleanupItemTransaction = "transactions/cleanup_item.cdc" | ||
| GetIDsScript = "scripts/read_storefront_ids.cdc" | ||
| GetListingDetailsScript = "scripts/read_listing_details.cdc" |
There was a problem hiding this comment.
These variables don't need to be exported from the package
There was a problem hiding this comment.
oh @psiemens it's actually interesting here -- so my intention was to export these names, so that you can load up the scripts later with ReadWithAddresses! Then you can do something similar to what's currently done in the test package (set up accounts, etc).
What's the idiomatic Flow way of doing that?
| if !recognizedAddresses[importFile] { | ||
| fmt.Printf("Did you mispell anything? Replacing '%s'...\n", importFile) | ||
| } |
There was a problem hiding this comment.
What's the purpose of the recognizedAddresses map? Does it just check that. addressMap doesn't contain an address that it doesn't recognize?
IMO you could simplify the code by removing this check -- this function is only called internally and I think it would actually be safer to assign "FungibleToken" and "NonFungibleToken" to constants that the top of this file to avoid spelling mistakes.
Co-authored-by: Peter Siemens <[email protected]>
Motivation
This allows NFT storefront code to be imported outside of this repo!
The
contractspackage is intentionally small - rather than relying onemulator(like the test package here), we only make it so that it can load up the Cadence files. Then, the emulator will decide what to do with them.Test plan
Test loading of contracts
make testin thelib/go/contractsdirectoryExisting tests (in lib/go/test)
make testin thelib/go/testdirectory