Propose staking support #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
reviewed
Jan 7, 2023
| @@ -44,9 +59,11 @@ pub contract FlowColdStorageProxy { | |||
| pub var lastNonce: Int64 | |||
| access(self) let flowVault: @FungibleToken.Vault | |||
| access(self) let publicKey: [UInt8] | |||
| access(self) let nodeDelegator: @FlowIDTableStaking.NodeDelegator | |||
There was a problem hiding this comment.
Is this contract already deployed on a network? You aren't able to add fields in upgrades, so you'd need to find another way to do this if it is already deployed
|
|
||
| init(publicKey: [UInt8]) { | ||
| init(publicKey: [UInt8], stakingNodeID: String) { |
There was a problem hiding this comment.
It is right to register a delegator for the user by default, or should there be a different method to allow them the option to register only if they want to?
Comment on lines
161
to
172
| var data: [UInt8] = "delegate".toBytes() | ||
| data = data.concat(amount.toBigEndianBytes()) | ||
| data = data.concat(nonce.toBigEndianBytes()) | ||
|
|
||
| // Verify the signature. | ||
| let key = PublicKey( | ||
| publicKey: self.publicKey, | ||
| signatureAlgorithm: SignatureAlgorithm.ECDSA_secp256k1 | ||
| ) | ||
| if !key.verify(signature: sig, signedData: data, domainSeparationTag: "FLOW-V0.0-user", hashAlgorithm: HashAlgorithm.SHA3_256) { | ||
| panic("Invalid meta transaction signature") | ||
| } |
There was a problem hiding this comment.
A lot of this code is boilerplate and is the same between the different methods. Would it be possible to split some of it out into utility methods to avoid boilerplate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for reference.
Basic and untested addition to the proxy vault which could be used to support staking for Custody