Add plan to upgrade the service account contract #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezpodhostnik
approved these changes
Jan 23, 2025
|
@vishalchangrani Do you think it would be possible to do this upgrade next tuesday? @janezpodhostnik Anything else that needs to be done before we do this upgrade on testnet? |
|
I would wait until after the next HCU, since that is when we will switch the FVM to read from the new account. |
|
@vishalchangrani Have you gotten a chance to look at this yet? Any idea when we'll be able to do the upgrade? |
|
This is good to go now as far as FVM is concerned. |
|
@joshuahannan has this been deployed on testnet? |
vishalchangrani
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an upgrade plan to add the functionality to the
FlowServiceAccountcontract to query theFlowExecutionParameterscontract for parameters values.From this PR: onflow/flow-core-contracts#469
I picked Jan 28th because it seemed logical, but it doesn't have to be that day