Replaced the APIs' rawValues with proper names. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizwan95
changed the title
|
@rizwan95 Hi mate, thanks for the PR 👍 I've been thinking about this, but in a sense I'm OK with rawValue, it's a bit tedious but it's something we have been used to, introducing some sugar around it is nice, but I would let it to be for the user of this lib to decide. |
|
@onmyway133 Okay then, let's leave it to the user. :) I personally feel that rawValue is a bit weird 😄 |
|
@rizwan95 Ja I agree. But I'm not too excited about adding sugar extension |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have replaced rawValues with proper API naming conventions. Hope it helps :) @onmyway133