Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner report on completed stages #68

Merged
merged 40 commits into from
Jan 10, 2024
Merged

Cleaner report on completed stages #68

merged 40 commits into from
Jan 10, 2024

Conversation

danielholanda
Copy link
Collaborator

@danielholanda danielholanda commented Dec 7, 2023

Closes #35

Description

This PR:

  • Splits stages_completed into status and duration
  • Sorts all columns of the report alphabetically
  • Renames all_build_stages to sequence_of_selected_stages so this information shows close to other state information in the report.

Note: Order of stages in the columns of the report can't be guaranteed, as different builds may have a different order of stages.

@danielholanda danielholanda self-assigned this Dec 7, 2023
@jeremyfowers jeremyfowers marked this pull request as draft December 15, 2023 19:01
@jeremyfowers
Copy link
Collaborator

Converting to draft until tests are passing, will review once its all green

Copy link
Collaborator

@jeremyfowers jeremyfowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome functional improvement! However, I would appreciate it if you could revisit some of the implementation choices. I think they will take very little time to adjust, but would make a big improvement for long-term durability.

@jeremyfowers jeremyfowers marked this pull request as ready for review January 10, 2024 16:25
Copy link
Collaborator

@jeremyfowers jeremyfowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have implemented my own suggestions... so I approve :)

@jeremyfowers jeremyfowers self-assigned this Jan 10, 2024
Copy link
Collaborator Author

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Please address the comments and I will have another quick review.

Copy link
Collaborator Author

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@jeremyfowers jeremyfowers merged commit f8e8c1f into main Jan 10, 2024
10 checks passed
@jeremyfowers jeremyfowers deleted the stage_order branch January 10, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stages_completed is out of order in the report
3 participants