-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner report on completed stages #68
Conversation
Remove the deprecated quantization tool Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
* Refactor build out of benchmarking Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
* Remove the SetSuccess stage (and the need for it) Signed-off-by: Jeremy Fowers <[email protected]> * Add a comment about deepcopy Signed-off-by: Jeremy Fowers <[email protected]> * Fix CI testing order * Move large test to bottom --------- Signed-off-by: Jeremy Fowers <[email protected]> Co-authored-by: Jeremy Fowers <[email protected]>
Converting to draft until tests are passing, will review once its all green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome functional improvement! However, I would appreciate it if you could revisit some of the implementation choices. I think they will take very little time to adjust, but would make a big improvement for long-term durability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have implemented my own suggestions... so I approve :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Please address the comments and I will have another quick review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Closes #35
Description
This PR:
stages_completed
into status and durationall_build_stages
tosequence_of_selected_stages
so this information shows close to other state information in the report.Note: Order of stages in the columns of the report can't be guaranteed, as different builds may have a different order of stages.