Fix binary paths when precompiling multiple suites. #1511
+82
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjacobs31
force-pushed
the
fix/ginkgo-build-compiled-reporting
branch
from
1ba25d7 to
baa6a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1510.
When precompiling multiple suites with one invocation of
go build, it currently takes the name of the first output binary and reports that as the output binary for every suite after that as well. When-o outputdiris passed toginkgo build, this doesn't happen.This PR doesn't use
goFlagsConfig.Ounless it was actually set beforehand, which prevents the suites from being reported incorrectly.