Skip to content

Commit

Permalink
chore(host): Remove TODOs (#438)
Browse files Browse the repository at this point in the history
Removes the TODO comments in the host server; The catch-all error
handling here fits our usecase.
  • Loading branch information
clabby authored Aug 21, 2024
1 parent ceef403 commit a61ab47
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions bin/host/src/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ where
P: PreimageOracleServer,
{
loop {
// TODO: More granular error handling. Some errors here are expected, such as the
// client closing the pipe, while others are not and should throw.
// Break the loop on any error. An error in this path indicates a closed pipe.
if server.next_preimage_request(fetcher).await.is_err() {
break;
}
Expand All @@ -110,8 +109,7 @@ where
H: HintReaderServer,
{
loop {
// TODO: More granular error handling. Some errors here are expected, such as the
// client closing the pipe, while others are not and should throw.
// Break the loop on any error. An error in this path indicates a closed pipe.
if server.next_hint(router).await.is_err() {
break;
}
Expand Down

0 comments on commit a61ab47

Please sign in to comment.