-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(host): Accelerate all BLS12-381 Precompiles #1010
Conversation
📚
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the host. Feel free to follow up in another PR or do it here, but this is only the host end of the equation - we'll also need to add accelerated versions of the precompiles in the client software (with limits on input size enforced.)
kona/bin/client/src/precompiles/mod.rs
Lines 47 to 49 in 2419b29
if spec_id.is_enabled_in(SpecId::ISTHMUS) { | |
ctx_precompiles.extend([bls12::FPVM_BLS12_PAIRING_ISTHMUS]); | |
} |
Looks like BLS pairing is already done :)
a3939d5
to
9781e24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Would love to see action tests covering these precompiles across op-program
+ kona
as a part of the Isthmus acceptance testing, but no need to rush those in. Nice work.
Description
Updates the
kona-host
to accelerate all BLS12-381 precompiles.Fixes #1000