Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workspace): kona-executor #259

Merged
merged 2 commits into from
Jun 16, 2024
Merged

chore(workspace): kona-executor #259

merged 2 commits into from
Jun 16, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jun 16, 2024

Overview

Splits out the executor in the client program into its own crate, so that it may be used downstream by other backends more easily. It is not coupled to any of the kona-preimage platforms, so teams like succinct can implement their own backends for the trie traits.

@clabby clabby added K-chore Kind: chore A-workspace Area: Top level workspace modifications labels Jun 16, 2024
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 16, 2024
@clabby clabby linked an issue Jun 16, 2024 that may be closed by this pull request
@clabby clabby force-pushed the cl/split-executor branch from b2c6b58 to ff600bc Compare June 16, 2024 16:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.3%. Comparing base (49a9d9c) to head (a2e5d79).

Files Patch % Lines
bin/programs/client/src/kona.rs 0.0% 4 Missing ⚠️
bin/programs/client/src/l1/driver.rs 0.0% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/client-derivation branch from 517634c to ca1024b Compare June 16, 2024 17:55
@clabby clabby force-pushed the cl/split-executor branch from ff600bc to 8960a74 Compare June 16, 2024 17:55
@clabby clabby force-pushed the cl/client-derivation branch from ca1024b to 4668b31 Compare June 16, 2024 20:16
@clabby clabby force-pushed the cl/split-executor branch from 8960a74 to a05b491 Compare June 16, 2024 20:16
@clabby clabby force-pushed the cl/client-derivation branch from 4668b31 to d328e14 Compare June 16, 2024 20:51
@clabby clabby force-pushed the cl/split-executor branch from a05b491 to 2ad541f Compare June 16, 2024 20:51
@clabby clabby force-pushed the cl/client-derivation branch from d328e14 to 8e07805 Compare June 16, 2024 21:36
@clabby clabby force-pushed the cl/split-executor branch from 2ad541f to 9384c7f Compare June 16, 2024 21:36
Splits out the executor in the client program into its own crate, so
that it may be used downstream by other backends more easily. It is not
coupled to any of the `kona-preimage` platforms, so teams like succinct
can implement their own backends for the trie traits.
@clabby clabby force-pushed the cl/split-executor branch from 9384c7f to d43b4da Compare June 16, 2024 21:50
@clabby clabby changed the base branch from cl/client-derivation to main June 16, 2024 21:50
@clabby clabby enabled auto-merge June 16, 2024 21:50
@refcell refcell disabled auto-merge June 16, 2024 22:10
@refcell refcell enabled auto-merge June 16, 2024 22:10
@clabby clabby force-pushed the cl/split-executor branch from d43b4da to 311c49e Compare June 16, 2024 22:16
@clabby clabby force-pushed the cl/split-executor branch from 311c49e to a2e5d79 Compare June 16, 2024 22:17
@refcell refcell added this pull request to the merge queue Jun 16, 2024
Merged via the queue into main with commit c38d4ea Jun 16, 2024
14 checks passed
This was referenced Jun 16, 2024
@clabby clabby deleted the cl/split-executor branch July 2, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace Area: Top level workspace modifications K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(workspace): Split the stateless executor into its own crate
3 participants