Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(executor): Builder pattern for StatelessL2BlockExecutor #339

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat(executor): Builder pattern for StatelessL2BlockExecutor #339

merged 1 commit into from
Jun 28, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jun 28, 2024

Overview

Adds a builder pattern for StatelessL2BlockExecutor, in preparation for more configuration such as precompile stubs.

@clabby Graphite App
Copy link
Collaborator Author

clabby commented Jun 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request Jun 28, 2024
Merged
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.7%. Comparing base (1143dd3) to head (fe21f5a).

Files Patch % Lines
crates/executor/src/builder.rs 92.8% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby self-assigned this Jun 28, 2024
@clabby clabby added K-feature Kind: feature A-executor Area: kona-executor crate labels Jun 28, 2024
@clabby clabby mentioned this pull request Jun 28, 2024
Merged
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 28, 2024
refcell
refcell approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@clabby clabby force-pushed the cl/executor-builder branch from c9bde10 to 5c1f7b8 Compare June 28, 2024 16:39
This was referenced Jun 28, 2024
Merged
Merged
@clabby clabby force-pushed the cl/executor-builder branch 3 times, most recently from c609dd1 to a080502 Compare June 28, 2024 17:34
@clabby
feat(executor): Builder pattern for StatelessL2BlockExecutor
fe21f5a 
## Overview

Adds a builder pattern for `StatelessL2BlockExecutor`, in preparation
for more configuration such as precompile stubs.
@clabby clabby force-pushed the cl/executor-builder branch from a080502 to fe21f5a Compare June 28, 2024 17:40
@clabby clabby added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit f900a1d Jun 28, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Closed
@clabby clabby deleted the cl/executor-builder branch July 2, 2024 03:36
This was referenced Jul 8, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-executor Area: kona-executor crate K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clabby @codecov-commenter @refcell