Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trusted-sync metrics url #363

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jul 9, 2024

Description

Fixes the default trusted-sync metrics url to use 0.0.0.0 instead of localhost by default so port 9000 is exposed externally for prometheus to scrape metrics.

Copy link
Collaborator Author

refcell commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell requested a review from clabby July 9, 2024 15:33
@refcell refcell added the A-examples label Jul 9, 2024 — with Graphite App
@refcell refcell self-assigned this Jul 9, 2024
@refcell refcell marked this pull request as ready for review July 9, 2024 15:33
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (22c1570) to head (713d772).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 105b633 Jul 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants