Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Reduce Origin Advance to Warn #372

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jul 11, 2024

Description

Reduces the origin advance error to warning.

If the next block isn't available causing an intended block fetch failure, this will error which happens often.

We should also work in some backoffs to the providers, especially for frequently repeated method calls like origin advancing.

Copy link
Collaborator Author

refcell commented Jul 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title fix(examples): reduce origin advance error to warn fix(examples): Reduce Origin Advance to Warn Jul 11, 2024
@refcell refcell requested a review from clabby July 11, 2024 14:05
@refcell refcell added K-chore Kind: chore A-examples labels Jul 11, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review July 11, 2024 14:05
@refcell refcell self-assigned this Jul 11, 2024
@refcell refcell requested a review from clabby July 11, 2024 17:37
@clabby clabby added this pull request to the merge queue Jul 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.7%. Comparing base (3b48fcb) to head (57dc57d).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 0cb5955 Jul 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants