Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Pipeline Reset #383

Merged
merged 8 commits into from
Jul 19, 2024
Merged

fix(derive): Pipeline Reset #383

merged 8 commits into from
Jul 19, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jul 17, 2024

Description

Since stage resets are done using head recursion, it's been broken since the bottom stage (L1 Traversal) always returns an Eof error, which bubbles up prior to any other stage resets. Without stages being properly reset, trusted-sync failed to actually prune any old block info in the l1 retrieval stage during the drift fast-forwarding logic. This causes trusted-sync to enter a stuck state where it continuously fetches for the invalid, potentially re-orged block.

Copy link
Collaborator Author

refcell commented Jul 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title disable walkback by default fix(derive): Pipeline Reset Jul 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

@refcell refcell requested a review from clabby July 17, 2024 13:57
@refcell refcell added K-bug Kind: bug A-derive Area: kona-derive crate A-examples labels Jul 17, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review July 17, 2024 13:57
@refcell refcell self-assigned this Jul 17, 2024
@refcell refcell added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 00e6bc8 Jul 19, 2024
20 checks passed
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-bug Kind: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants