Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(derive): Remove PreviousStage Trait #423

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 11, 2024

Description

Removes the PreviousStage trait which is a relic from the reference derivation pipeline implementation where resetting stages needed to occur sequentially and the node driver needs to "walk back" the stages, resetting each one individually.

Metadata

Fixes #406

@refcell refcell changed the title chore(derive): remove previous stage trait chore(derive): Remove PreviousStage Trait Aug 11, 2024
Copy link
Collaborator Author

refcell commented Aug 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell requested a review from clabby August 11, 2024 14:49
@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate M-traits Meta: Touches Trait Abstractions labels Aug 11, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review August 11, 2024 14:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (8fd9f44) to head (07b7314).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell self-assigned this Aug 12, 2024
@refcell refcell added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 19123e3 Aug 12, 2024
20 checks passed
This was referenced Aug 12, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-chore Kind: chore M-traits Meta: Touches Trait Abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(derive): Remove PreviousStage Trait
3 participants