feat(client): Walkback Channel Timeout in Sad Path

[refcell]

Description

An alternative to #424 that walks back the channel_timeout in the sad path when the pipeline fails to decode a batch from ready channel data.

Metadata

Fixes #417

[refcell]

• feat(client): Walkback Channel Timeout in Sad Path #427 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 47.05882% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (19b00f3) to head (31775c0).

Files	Patch %	Lines
crates/derive/src/pipeline/core.rs	0.0%	9 Missing ⚠️
crates/derive/src/stages/channel_reader.rs	65.0%	7 Missing ⚠️
crates/derive/src/errors.rs	0.0%	1 Missing ⚠️
crates/derive/src/stages/batch_queue.rs	66.6%	1 Missing ⚠️

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[clabby]

This looks good overall. Curious about that TODO.

[refcell]

This does not prevent a malicious batcher from posting multiple valid frames within the channel window where the first frame is missed because it is posted prior to the l1 origin....

[refcell]

Closing for now. Holocene should fix and if we absolutely need, can always re-open.