Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Break when the pipeline cannot advance #478

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Sep 2, 2024

Overview

Breaks the produce_disputed_payload loop if the pipeline cannot advance. This needs more investigation wrt. alternative errors being "temporary," but does address current issues with not haulting derivation upon critical errors.

Copy link
Collaborator Author

clabby commented Sep 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby self-assigned this Sep 2, 2024
@clabby clabby added K-fix Kind: fix A-client Area: client binary labels Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.3%. Comparing base (8fca6ec) to head (6ff451b).
Report is 3 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit bea2f62 Sep 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client binary K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants