Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(primitives): op-alloy Frame Type #492

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(primitives): op-alloy Frame Type #492

merged 1 commit into from
Sep 5, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 5, 2024

Description

Removes the frame module from kona-primitives in favor of using the one from upstream op-alloy-protocol.

Will put up an issue to remove the patch.crates-io once the op-alloy-protocol pr lands and the version is bumped.

Closes #487

@refcell refcell self-assigned this Sep 5, 2024
@refcell refcell requested a review from clabby September 5, 2024 13:07
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (b1ebc3c) to head (71c8141).
Report is 2 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby
Copy link
Collaborator

clabby commented Sep 5, 2024

Looks like there's other types (Channel, BlockInfo, etc.) that we can migrate as well - can we do that now? https://github.com/alloy-rs/op-alloy/tree/main/crates/protocol/src

@refcell
Copy link
Collaborator Author

refcell commented Sep 5, 2024

Looks like there's other types (Channel, BlockInfo, etc.) that we can migrate as well - can we do that now? alloy-rs/op-alloy@main/crates/protocol/src

Working on this in follow-on prs atm. They're more complicated.

Generally, it is ok to have incremental prs

@refcell refcell added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 67e5d0a Sep 5, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@github-actions github-actions bot mentioned this pull request Sep 6, 2024
This was referenced Sep 21, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(primitives): Remove Frame
2 participants