fix(IndexedBlobHash
): Change index
to u64
#846
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 64-bit architectures the behavior of
to_be_bytes
forusize
andu32
is the same, but in 32-bit architectures (e.g. SP1),to_be_bytes
for ausize
outputs 4 bytes instead of the expected 8 bytes.This leads to the following error when getting blobs:
Asterisc is a 64-bit architecture, which is why I think this issue wasn't caught: https://github.com/ethereum-optimism/asterisc.
Can we add CI for running a
kona
program in a 32-bit architecture? Happy to make a PR to ensure that consumers ofkona
(e.g.op-succinct
) aren't impacted.