Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(executor): Update SpecId with Isthmus #962

Merged
merged 1 commit into from
Jan 28, 2025
Merged

chore(executor): Update SpecId with Isthmus #962

merged 1 commit into from
Jan 28, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jan 28, 2025

Description

Updates the revm SpecId with Isthmus.

Closes #947.

@refcell refcell requested a review from clabby as a code owner January 28, 2025 16:45
@refcell refcell self-assigned this Jan 28, 2025
@refcell refcell requested a review from emhane as a code owner January 28, 2025 16:45
@refcell
Copy link
Collaborator Author

refcell commented Jan 28, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.8%. Comparing base (c017eea) to head (b105404).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/executor/env.rs 66.6% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emhane
Copy link
Member

emhane commented Jan 28, 2025

this code appears duplicate in op-reth, perhaps would be nice to move into maili to avoid having to update in two places

@refcell
Copy link
Collaborator Author

refcell commented Jan 28, 2025

this code appears duplicate in op-reth, perhaps would be nice to move into maili to avoid having to update in two places

Agreed. Let's write up a ticket to track

@refcell refcell merged commit 4e5325b into main Jan 28, 2025
15 of 16 checks passed
@refcell refcell deleted the rf/env-update branch January 28, 2025 18:30
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dep(workspace): Upgrade + integrate revm with Isthmus support
2 participants