Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): Don't generate a diff when running tests #967

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 28, 2025

Overview

Tars up the test fixtures for kona-executor and uses temp directories to run the stateless L2 block executor tests. This prevents a diff from being created when the tests are ran for the kona-executor crate.

@clabby clabby added M-tests Meta: Testing related K-fix Kind: fix A-executor Area: kona-executor crate labels Jan 28, 2025
@clabby clabby self-assigned this Jan 28, 2025
@clabby clabby requested review from refcell and emhane as code owners January 28, 2025 18:39
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.4%. Comparing base (66e94c6) to head (8a7b8cc).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell enabled auto-merge January 28, 2025 18:43
@refcell refcell added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit abac13f Jan 28, 2025
16 checks passed
@refcell refcell deleted the cl/tar-testdata branch January 28, 2025 19:01
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate K-fix Kind: fix M-tests Meta: Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants