Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): Withdrawals root #974

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix(executor): Withdrawals root #974

merged 1 commit into from
Jan 29, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 29, 2025

Overview

Fixes the withdrawals root feature of Isthmus. It's not currently enabled, but there was also a logic flaw where it fetched the L2ToL1MessagePasser's storage root for the parent block, not the current block.

@clabby clabby added K-fix Kind: fix A-executor Area: kona-executor crate H-isthmus Hardfork: Isthmus related labels Jan 29, 2025
@clabby clabby self-assigned this Jan 29, 2025
@clabby clabby requested review from refcell and emhane as code owners January 29, 2025 15:09
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.8%. Comparing base (b3ce5ee) to head (c5c62fa).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/executor/mod.rs 11.1% 8 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw

the trieaccount looks identical to

https://github.com/alloy-rs/trie/blob/main/src/account.rs

@clabby
Copy link
Collaborator Author

clabby commented Jan 29, 2025

btw

the trieaccount looks identical to

https://github.com/alloy-rs/trie/blob/main/src/account.rs

Nice. We'll de-dup that.

@clabby
Copy link
Collaborator Author

clabby commented Jan 29, 2025

@mattsse #975

@refcell refcell merged commit 01aba48 into main Jan 29, 2025
15 of 16 checks passed
@refcell refcell deleted the cl/wd-root-fix branch January 29, 2025 15:27
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate H-isthmus Hardfork: Isthmus related K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants