Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(executor): De-duplicate TrieAccount type #977

Merged
merged 1 commit into from
Jan 29, 2025
Merged

chore(executor): De-duplicate TrieAccount type #977

merged 1 commit into from
Jan 29, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 29, 2025

Overview

De-duplicates the TrieAccount type in favor of using alloy-trie's.

closes #975

@clabby clabby added K-chore Kind: chore F-deps Flag: Updates dependencies A-executor Area: kona-executor crate labels Jan 29, 2025
@clabby clabby self-assigned this Jan 29, 2025
@clabby clabby requested review from refcell and emhane as code owners January 29, 2025 16:38
refcell
refcell approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.7%. Comparing base (c8b6b95) to head (8dab92b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby enabled auto-merge January 29, 2025 16:40
@clabby clabby added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 71a02cc Jan 29, 2025
16 checks passed
@clabby clabby deleted the cl/de-dup-trie-acc branch January 29, 2025 16:54
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@clabby clabby

Labels
A-executor Area: kona-executor crate F-deps Flag: Updates dependencies K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(executor): De-duplicate TrieAccount
2 participants
@clabby @refcell