Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(protocol): Rejigger L1 Block Info Tx Calldata Parsing #235

Merged
merged 2 commits into from
Feb 11, 2025
Merged

chore(protocol): Rejigger L1 Block Info Tx Calldata Parsing #235

merged 2 commits into from
Feb 11, 2025

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Feb 11, 2025 •
edited
Loading

Description

Re-jiggers the L1BlockInfoTx calldata parsing to use concrete error types and direct slice referencing with safety.

This avoids missing test coverage over errors that cannot be thrown due to bound checks.

Closes #229

@refcell refcell requested a review from mattsse as a code owner February 11, 2025 17:16
@refcell refcell added the A-protocol Area: protocol crate label Feb 11, 2025
@refcell refcell requested a review from emhane as a code owner February 11, 2025 17:16
@refcell refcell added the C-chore Category: general cleanup label Feb 11, 2025
@refcell refcell requested a review from clabby as a code owner February 11, 2025 17:16
@refcell refcell added the H-isthmus Hardfork: isthmus label Feb 11, 2025
@refcell refcell self-assigned this Feb 11, 2025
@refcell
Copy link
Contributor Author

refcell commented Feb 11, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.66443% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.8%. Comparing base (50e7e61) to head (93b8e03).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/protocol/src/info/variant.rs 97.4% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell merged commit 48a9e99 into main Feb 11, 2025
24 checks passed
@refcell refcell deleted the rf/test-isthmus-l1-block-info branch February 11, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees

@refcell refcell

Labels
A-protocol Area: protocol crate C-chore Category: general cleanup H-isthmus Hardfork: isthmus
Projects
Project Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Test Coverage over Isthmus L1 Block Info
1 participant
@refcell