Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): std leaking into tests #241

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix(protocol): std leaking into tests #241

merged 1 commit into from
Feb 11, 2025

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Feb 11, 2025

Description

Fixes the maili-protocol crate to not have std leaking into tests.

Closes #224

@refcell refcell self-assigned this Feb 11, 2025
@refcell refcell requested a review from clabby as a code owner February 11, 2025 21:40
@refcell
Copy link
Contributor Author

refcell commented Feb 11, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.4%. Comparing base (64066b7) to head (894345c).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/protocol/src/block.rs Show resolved Hide resolved
@refcell refcell merged commit e61aa2e into main Feb 11, 2025
24 checks passed
@refcell refcell deleted the rf/test-leakage branch February 11, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Feature Leakage in Maili Protocol Testing
2 participants