Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(rpc): Smol perf improvement SupervisorApi, pass slice instead of vec as param #28

Merged
merged 2 commits into from
Jan 9, 2025
Merged

perf(rpc): Smol perf improvement SupervisorApi, pass slice instead of vec as param #28

merged 2 commits into from
Jan 9, 2025

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 9, 2025

Passes a slice of EngineMessages instead of a vector in SupervisorApi::check_messages

@emhane emhane added the A-rpc Area: rpc crates label Jan 9, 2025
@refcell refcell merged commit 2e9a61c into main Jan 9, 2025
20 checks passed
@refcell refcell deleted the emhane/supervsior-api branch January 9, 2025 15:20
emhane added a commit that referenced this pull request Jan 9, 2025
@emhane
perf(rpc): Smol perf improvement SupervisorApi, pass slice instead …
46b9cab 
…of vec as param (#28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees
No one assigned
Labels
A-rpc Area: rpc crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @refcell