-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MinIO Object Store event based dataprep and retriever using Milvus and LanceDB #846
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@lvliang-intel would you kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @chensuyue do we need any tests?
"parent": "" | ||
}, | ||
{ | ||
"name": "uploaded_file_2.txt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to change one of these to a file path/url. What is the name of a file when it is path? id == name?
Yes, we need some one test for each microservice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below are few minor comments on the docs and Python code.
As to Dockerfiles, see: opea-project/GenAIExamples#225
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
for more information, see https://pre-commit.ci
@dilverse, |
@lvliang-intel Updated the github workflow |
Description
MinIO is a high performance Object Storage solution which is fully S3 compatible and using which its easier to build highly scalable applications. In this PR adding support for the following
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.